solUnimplementedAssert in codegen

ethereum · May 20, 2024 · 2892ee4 · 2892ee4
1 parent 4e2f72a
commit 2892ee4
Show file tree

Hide file tree

Showing 10 changed files with 33 additions and 1 deletion.
diff --git a/libsolidity/interface/CompilerStack.cpp b/libsolidity/interface/CompilerStack.cpp
@@ -1467,6 +1467,11 @@ void CompilerStack::compileContract(
 	solUnimplementedAssert(!m_eofVersion.has_value(), "Experimental EOF support is only available for via-IR compilation.");
 	solAssert(m_stackState >= AnalysisSuccessful, "");
 
+	solUnimplementedAssert(ranges::all_of(
+		_contract.stateVariables(),
+		[](auto const* _stateVar) { return _stateVar->referenceLocation() != VariableDeclaration::Location::Transient; }
+	));
+
 	if (_otherCompilers.count(&_contract))
 		return;
 
@@ -1496,6 +1501,11 @@ void CompilerStack::generateIR(ContractDefinition const& _contract)
 {
 	solAssert(m_stackState >= AnalysisSuccessful, "");
 
+	solUnimplementedAssert(ranges::all_of(
+		_contract.stateVariables(),
+		[](auto const* _stateVar) { return _stateVar->referenceLocation() != VariableDeclaration::Location::Transient; }
+	));
+
 	Contract& compiledContract = m_contracts.at(_contract.fullyQualifiedName());
 	if (!compiledContract.yulIR.empty())
 		return;
@@ -1579,6 +1589,11 @@ void CompilerStack::generateEVMFromIR(ContractDefinition const& _contract)
 {
 	solAssert(m_stackState >= AnalysisSuccessful, "");
 
+	solUnimplementedAssert(ranges::all_of(
+		_contract.stateVariables(),
+		[](auto const* _stateVar) { return _stateVar->referenceLocation() != VariableDeclaration::Location::Transient; }
+	));
+
 	if (!_contract.canBeDeployed())
 		return;
 

diff --git a/test/libsolidity/syntaxTests/dataLocations/transient_function_type.sol b/test/libsolidity/syntaxTests/dataLocations/transient_function_type.sol
@@ -6,4 +6,6 @@ contract C {
     function () internal transient internal fiti;
     function () internal internal transient fiit;
 }
+// ====
+// stopAfter: analysis
 // ----
diff --git a/test/libsolidity/syntaxTests/dataLocations/transient_reference_type_state_variables.sol b/test/libsolidity/syntaxTests/dataLocations/transient_reference_type_state_variables.sol
@@ -8,5 +8,7 @@ contract C {
 	S transient s;
 	mapping(uint => uint) transient y;
 }
+// ====
+// stopAfter: analysis
 // ----
 // UnimplementedFeatureError: Transient data location is only supported for value types.
diff --git a/test/libsolidity/syntaxTests/dataLocations/transient_state_variable_visibility.sol b/test/libsolidity/syntaxTests/dataLocations/transient_state_variable_visibility.sol
@@ -7,4 +7,6 @@ contract C {
     uint transient internal ti;
     uint transient private tprv;
 }
+// ====
+// stopAfter: parsing
 // ----
diff --git a/test/libsolidity/syntaxTests/dataLocations/transient_value_type_state_variables.sol b/test/libsolidity/syntaxTests/dataLocations/transient_value_type_state_variables.sol
@@ -7,4 +7,6 @@ contract C {
 	uint transient x;
 	bytes32 transient y;
 }
+// ====
+// stopAfter: parsing
 // ----
diff --git a/...libsolidity/syntaxTests/dataLocations/transient_value_type_state_variables_assignment.sol b/...libsolidity/syntaxTests/dataLocations/transient_value_type_state_variables_assignment.sol
@@ -5,4 +5,6 @@ contract C {
 	address transient a = address(0xABC);
 	bool transient b = x > 0 ? false : true;
 }
+// ====
+// stopAfter: parsing
 // ----
diff --git a/...solidity/syntaxTests/functionTypes/transient_function_type_with_param_named_transient.sol b/...solidity/syntaxTests/functionTypes/transient_function_type_with_param_named_transient.sol
@@ -1,5 +1,6 @@
 contract C {
     function (uint transient) external transient y;
 }
+// ====
+// stopAfter: parsing
 // ----
-// Warning 6162: (27-41): Naming function type parameters is deprecated.
diff --git a/test/libsolidity/syntaxTests/operators/transient_value_type.sol b/test/libsolidity/syntaxTests/operators/transient_value_type.sol
@@ -6,4 +6,6 @@ contract C {
         return (x + w) * (y / x);
     }
 }
+// ====
+// stopAfter: parsing
 // ----
diff --git a/test/libsolidity/syntaxTests/types/address/state_variable_address_payable_transient.sol b/test/libsolidity/syntaxTests/types/address/state_variable_address_payable_transient.sol
@@ -1,4 +1,6 @@
 contract C {
     address payable transient a;
 }
+// ====
+// stopAfter: parsing
 // ----
diff --git a/...libsolidity/syntaxTests/variableDeclaration/transient_as_identifier_and_data_location.sol b/...libsolidity/syntaxTests/variableDeclaration/transient_as_identifier_and_data_location.sol
@@ -1,4 +1,6 @@
 contract C {
 	uint transient transient;
 }
+// ====
+// stopAfter: parsing
 // ----