Fix segmentation fault when assigning to a parenthesized non-tuple expression of a tuple type #15084
+43
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0qs
changed the title
r0qs
force-pushed
the
fix-segfault-tuple-expression
branch
2 times, most recently
from
184d65f
to
ad74d10
Compare
cameel
reviewed
May 8, 2024
There was a problem hiding this comment.
The new condition is technically incorrect (or rather makes unnecessary assumptions), though cases that it would process incorrectly are currently impossible in the language, so the code is not buggy despite this. I think it would still be better to correct it before we merge the PR.
test/libsolidity/syntaxTests/tupleAssignments/empty_tuple_lhs_resolved.sol
Outdated
Show resolved
Hide resolved
r0qs
force-pushed
the
fix-segfault-tuple-expression
branch
2 times, most recently
from
0b0192c
to
0646e8f
Compare
r0qs
changed the title
r0qs
force-pushed
the
fix-segfault-tuple-expression
branch
from
0646e8f
to
c88b3cf
Compare
cameel
reviewed
May 10, 2024
cameel
reviewed
May 10, 2024
test/libsolidity/syntaxTests/tupleAssignments/empty_tuples_lhs_resolved.sol
Outdated
Show resolved
Hide resolved
cameel
previously approved these changes
May 10, 2024
cameel
changed the title
cameel
changed the title
r0qs
force-pushed
the
fix-segfault-tuple-expression
branch
5 times, most recently
from
b8eb208
to
3ec1ed6
Compare
cameel
reviewed
May 13, 2024
...ntaxTests/tupleAssignments/assignments_to_tuple_and_non_tuple_expressions_of_tuple_types.sol
Outdated
Show resolved
Hide resolved
...ntaxTests/tupleAssignments/assignments_to_tuple_and_non_tuple_expressions_of_tuple_types.sol
Outdated
Show resolved
Hide resolved
r0qs
force-pushed
the
fix-segfault-tuple-expression
branch
from
6efbf56
to
e53197d
Compare
r0qs
force-pushed
the
fix-segfault-tuple-expression
branch
from
e53197d
to
3b4d9bb
Compare
cameel
reviewed
May 14, 2024
...ntaxTests/tupleAssignments/assignments_to_tuple_and_non_tuple_expressions_of_tuple_types.sol
Outdated
Show resolved
Hide resolved
r0qs
force-pushed
the
fix-segfault-tuple-expression
branch
from
a86dd89
to
2d0fcb0
Compare
…pression of a tuple type Co-authored-by: Kamil Śliwak <kamil.sliwak@codepoets.it>
r0qs
force-pushed
the
fix-segfault-tuple-expression
branch
from
2d0fcb0
to
5ffd39a
Compare
cameel
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15075