Fix blockTag not being included on estimateGas calls #4610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricmoo
added
investigate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
blockTagoption forestimateGasis in the documentation and part of the Ethereum RPC spec, but it doesn't currently work in ethers. The option is defined on the input typeTransactionRequest, but it's silently ignored in the processing code.This fixes (or adds) this feature to enable blockTags on estimateGas. It uses it in the same manner and functions that
calland other commands do, so it accepts the usual options (likepending,latest, a specific block numbers, etc.).I think this covers the relevant code sections from my searching, but let me know if there's other fixes needed.