[vscode] Use the python extension venv #820

vthemelis · 2024-03-31T00:41:24Z

Summary

Fixes #6
Fixes #645
Fixes #183

If the VsCode Python extension is installed, use the Python interpreter that is selected in the extension to start the pyre language server. Also, subscribe to environment switches and restart the pyre language server with the new environments.

If the extension is not present, we retain the original behaviour of the extension.

This is very useful for people that may have multiple environments installed but is more useful for people that use the VsCode SSH extension and cannot benefit from this workaround.

Test Plan

I ran the extension locally and it seems to be picking up the interpreter path.

vthemelis · 2024-03-31T00:50:15Z

tools/ide_plugins/vscode/package.json

@@ -34,7 +34,7 @@
    "cson": "^4.1.0",
    "tslint": "^5.8.0",
    "tslint-microsoft-contrib": "^5.0.1",
-    "typescript": "^2.6.1",
+    "typescript": "^3.7",


I think it would be good to also add a lock file. This can make it easier to replicate successful builds. I can do this in a separate PR.

vthemelis · 2024-04-02T08:26:52Z

Hi @connernilsen, would it be possible to get a review on this? It's pretty awkward to use the pyre vscode extension without this change.

connernilsen · 2024-04-03T20:14:45Z

Hey @vthemelis, thanks for the PR! I'm honestly not too familiar with this part of Pyre. Let me see if I can find someone who is more familiar with it and can provide a good review.

vthemelis · 2024-04-03T22:18:38Z

Thank you very much @connernilsen !

vthemelis · 2024-04-10T15:21:04Z

Hi guys, can I still get a review for this?

connernilsen · 2024-04-11T15:43:56Z

Sorry, this fell through the cracks last week. Reaching out to people now.

vthemelis · 2024-04-11T19:10:27Z

thank you! 🙏

connernilsen · 2024-04-15T19:01:33Z

Alright @vthemelis, thanks for making these changes! The following is a followup that one of my teammates requested:

Would you be able to add a command palette item for allowing changes to this without having to restart VSCode? It looks like the changes here would only work for the initial startup workflow.

vthemelis · 2024-04-16T12:29:23Z

Thanks for the review @connernilsen!

There is an event listener that restarts pyre when the user switches environments here

https://github.com/facebook/pyre-check/pull/820/files#diff-1141a7840adc35ecfd0234d6fe8484e7aec33f72306fd32bada0037336ea1f3eR47-R56

Did that not work for you?

I'm happy to also add a palette item as well. Would that be for restarting the Pyre server in the extensions?

facebook-github-bot · 2024-04-16T19:32:17Z

@kinto0 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

vthemelis · 2024-04-22T21:32:10Z

Hello @kinto0, thanks for importing the PR! Is there anything I can do to help merge it?

cclauss · 2024-04-24T17:01:06Z

For test failures on Python < 3.10 see:

Run GitHub Actions tests on current versions of Python #832

Would this properly address the situation where I pipx install pyre-check ?

vthemelis · 2024-04-24T20:52:44Z

For test failures on Python < 3.10 see:

Run GitHub Actions tests on current versions of Python #832

Thanks, I can merge main into this branch once you merge this PR.

Would this properly address the situation where I pipx install pyre-check ?

I don't think so. It's not really how I use pyre (I install it in my local environment) but can look into this in a separate PR.

tools/ide_plugins/vscode/package.json

kinto0 · 2024-04-29T17:14:23Z

sorry about the delay. we had some issues authenticating with the vscode store blocking us from deploying new extensions that should be resolved soon.

kinto0

would you mind taking a look at my error? I see it when testing with or without the python extension enabled

vthemelis · 2024-04-29T22:18:19Z

would you mind taking a look at my error? I see it when testing with or without the python extension enabled

Thanks a lot for the review @kinto0 ! I pushed a commit to fix the issue. See: #820 (comment)

vthemelis · 2024-05-07T23:12:34Z

@kinto0, does this work for you now?

kinto0 · 2024-05-09T14:34:03Z

@kinto0, does this work for you now?

did you make a change? I don't see it on my side

vthemelis · 2024-05-10T01:44:48Z

did you make a change? I don't see it on my side

Yes, it's the last commit in the PR. It's also referenced by hash in my reply to your in-line comment.

You may need to import the commit in Phabricator.

kinto0

I left this review after e9147b2 but forgot to publish it... my bad.

kinto0 · 2024-04-30T04:20:17Z

tools/ide_plugins/vscode/src/main.ts

+	const activatedEnvPath = pythonExtension.exports.environments.getActiveEnvironmentPath();
+	const pyrePath = inferPyreCommand(activatedEnvPath);
+
+	if (pyrePath) {


if no pyrePath, we should resort to the default one

I added an extra case in the findPyreCommand and it now will look in PATH for pyre to use as a fallback.

kinto0 · 2024-04-30T04:28:50Z

tools/ide_plugins/vscode/src/main.ts

+	return {languageClient, configListener};
+}
+
+function inferPyreCommand(envPath: EnvironmentPath) : string | undefined {


could you rename this findPyreCommand? infer has a connotation of type inference within the codebase

tools/ide_plugins/vscode/src/main.ts

vthemelis · 2024-05-11T11:49:06Z

@kinto0 , thanks, pushed another commit.

* `s/inferPyre/findPyre/g` * Use the default pyre command as a fallback if it exists.

vthemelis · 2024-05-16T23:11:00Z

Hi @kinto0 , anything else I can do to help merge this?

vthemelis · 2024-05-20T18:37:46Z

@kinto0 friendly ping :)

facebook-github-bot added the CLA Signed label Mar 31, 2024

vthemelis force-pushed the use-vscode-venv branch 2 times, most recently from df8cc87 to 592a3c3 Compare March 31, 2024 00:42

vthemelis changed the title ~~Select the python path of the VSCode venv~~ [vscode] Use activated venv Mar 31, 2024

vthemelis commented Mar 31, 2024

View reviewed changes

vthemelis force-pushed the use-vscode-venv branch 7 times, most recently from 12e1506 to c132e3a Compare March 31, 2024 18:07

vthemelis changed the title ~~[vscode] Use activated venv~~ [vscode] Use the python extension venv Apr 3, 2024

vthemelis force-pushed the use-vscode-venv branch 3 times, most recently from 8322e8f to 5892a19 Compare April 4, 2024 22:57

[vscode] Use the python extension venv

5b70c7f

vthemelis force-pushed the use-vscode-venv branch from ac84dea to 5b70c7f Compare April 7, 2024 17:31

kinto0 reviewed Apr 29, 2024

View reviewed changes

tools/ide_plugins/vscode/package.json Outdated Show resolved Hide resolved

kinto0 requested changes Apr 29, 2024

View reviewed changes

Move @vscode/python-extension to non-dev-deps

e9147b2

kinto0 reviewed May 10, 2024

View reviewed changes

vthemelis force-pushed the use-vscode-venv branch from f271c97 to c36598d Compare May 11, 2024 11:50

PR review comments:

737154b

* `s/inferPyre/findPyre/g` * Use the default pyre command as a fallback if it exists.

vthemelis force-pushed the use-vscode-venv branch from c36598d to 737154b Compare May 11, 2024 12:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[vscode] Use the python extension venv #820

[vscode] Use the python extension venv #820

vthemelis commented Mar 31, 2024 •

edited

vthemelis Mar 31, 2024

vthemelis commented Apr 2, 2024

connernilsen commented Apr 3, 2024

vthemelis commented Apr 3, 2024

vthemelis commented Apr 10, 2024

connernilsen commented Apr 11, 2024

vthemelis commented Apr 11, 2024

connernilsen commented Apr 15, 2024

vthemelis commented Apr 16, 2024 •

edited

facebook-github-bot commented Apr 16, 2024

vthemelis commented Apr 22, 2024 •

edited

cclauss commented Apr 24, 2024

vthemelis commented Apr 24, 2024

kinto0 commented Apr 29, 2024

kinto0 left a comment

vthemelis commented Apr 29, 2024 •

edited

vthemelis commented May 7, 2024

kinto0 commented May 9, 2024

vthemelis commented May 10, 2024

kinto0 left a comment

kinto0 Apr 30, 2024

vthemelis May 11, 2024

kinto0 Apr 30, 2024

vthemelis May 11, 2024

vthemelis commented May 11, 2024

vthemelis commented May 16, 2024

vthemelis commented May 20, 2024

[vscode] Use the python extension venv #820

Are you sure you want to change the base?

[vscode] Use the python extension venv #820

Conversation

vthemelis commented Mar 31, 2024 • edited

Summary

Test Plan

vthemelis Mar 31, 2024

Choose a reason for hiding this comment

vthemelis commented Apr 2, 2024

connernilsen commented Apr 3, 2024

vthemelis commented Apr 3, 2024

vthemelis commented Apr 10, 2024

connernilsen commented Apr 11, 2024

vthemelis commented Apr 11, 2024

connernilsen commented Apr 15, 2024

vthemelis commented Apr 16, 2024 • edited

facebook-github-bot commented Apr 16, 2024

vthemelis commented Apr 22, 2024 • edited

cclauss commented Apr 24, 2024

vthemelis commented Apr 24, 2024

kinto0 commented Apr 29, 2024

kinto0 left a comment

Choose a reason for hiding this comment

vthemelis commented Apr 29, 2024 • edited

vthemelis commented May 7, 2024

kinto0 commented May 9, 2024

vthemelis commented May 10, 2024

kinto0 left a comment

Choose a reason for hiding this comment

kinto0 Apr 30, 2024

Choose a reason for hiding this comment

vthemelis May 11, 2024

Choose a reason for hiding this comment

kinto0 Apr 30, 2024

Choose a reason for hiding this comment

vthemelis May 11, 2024

Choose a reason for hiding this comment

vthemelis commented May 11, 2024

vthemelis commented May 16, 2024

vthemelis commented May 20, 2024

vthemelis commented Mar 31, 2024 •

edited

vthemelis commented Apr 16, 2024 •

edited

vthemelis commented Apr 22, 2024 •

edited

vthemelis commented Apr 29, 2024 •

edited