Fix a few last instances of patch
#852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D57359996 |
Summary: Our uses of `patch(...)` are broken for open-source, because in our current open-source CI our `__name__` involves `pyre-check`, which is not legal to use. As a result, for patching anything internal we need to use `patch.object` instead. It's okay to use `patch(...)` for stdlib, that doesn't cause problems (although I do wish we didn't have to rely on patching quite so much!) I'm breaking this into a couple of diffs to keep them small. Differential Revision: D57358329
Summary: This is the second of two commits removing the use of `unittest.patch` on pyre-internal functions and classes; instead we need to always use `patch.object` to avoid getting errors on invalid names in github CI. Differential Revision: D57359461
|
This pull request was exported from Phabricator. Differential Revision: D57359996 |
stroxler
force-pushed
the
export-D57359996
branch
from
3e1b7f2
to
773b55c
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
May 14, 2024
facebook-github-bot
pushed a commit
that referenced
this pull request
May 14, 2024
|
This pull request has been merged in 1b4d431. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I have to stack a separate commit because there's a closed
PR that the bot won't seem to let me reopen, and I need
to test these changes on github :/
Differential Revision: D57359996