-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spaceship] Check if app removed from sale #21902
Open
lucgrabowski
wants to merge
18
commits into
master
Choose a base branch
from
lucgrabowski-check-if-app-removed-from-sale
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st - the same way as in open api specs
…h longer url with services-account
…tion but unavailable)
Generated by 🚫 Danger |
1 similar comment
Generated by 🚫 Danger |
Should we also check if |
…o lucgrabowski-check-if-app-removed-from-sale
…o lucgrabowski-check-if-app-removed-from-sale
… app store versions - change logic in removed_from_sale? helper
lucgrabowski
commented
Mar 11, 2024
@@ -66,6 +66,14 @@ def self.type | |||
return "apps" | |||
end | |||
|
|||
def removed_from_sale? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if it shouldn't be renamed to removed_from_sale_or_not_ready?
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
As described in #21890,
Developer Removed from Sale
state was removed fromapp store version
and there was no way of checking if app is removed.This PR should be considered after #21900 and #21901 are handled.
Description
This PR adds a
removed_from_sale?
helper method toApp
model to check if app is removed from sale.As a first step it checks if app has a
ready for distribution
app store version.Next it checks if app is unavailable in all the territories and if that is the case, it means that the app was removed from sale.
Testing Steps
Tested with spaceship playground with apps that are ready for distribution and removed from sale.