Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add hiddenFields to app & website surveys #2628

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

gupta-piyush19
Copy link
Contributor

What does this PR do?

Adds hidden fields to app & website surveys.

Fixes
https://github.com/formbricks/internal/issues/177

How should this be tested?

  • Create a survey and add a few hidden fields to it.
  • Use formbricks.track method to pass the hidden fields(inside properties) to the survey response.
 formbricks.track("my event", {
      hiddenFields: {
        myField: "my value",
      },
    });

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview May 30, 2024 0:07am
formbricks-docs ⬜️ Ignored (Inspect) Visit Preview May 30, 2024 0:07am

Copy link
Contributor

github-actions bot commented May 15, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@gupta-piyush19 gupta-piyush19 marked this pull request as ready for review May 15, 2024 10:50
Copy link
Contributor

@pandeymangg pandeymangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks and works great! thanks for the PR mate, just added two small comments (nit), pls take a look

apps/web/app/s/[surveyId]/components/LinkSurvey.tsx Outdated Show resolved Hide resolved
packages/js-core/src/shared/utils.ts Outdated Show resolved Hide resolved
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gupta-piyush19 thanks :-) looks great in general. Only a few suggestions regarding the type naming and logs:

packages/types/js.ts Outdated Show resolved Hide resolved
packages/types/surveys.ts Outdated Show resolved Hide resolved
packages/js-core/src/shared/utils.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants