-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add hiddenFields to app & website surveys #2628
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Thank you for following the naming conventions for pull request titles! 🙏 |
…177-add-hiddenfields-to-app-website-surveys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks and works great! thanks for the PR mate, just added two small comments (nit), pls take a look
…177-add-hiddenfields-to-app-website-surveys
…/github.com/formbricks/formbricks into 177-add-hiddenfields-to-app-website-surveys
…177-add-hiddenfields-to-app-website-surveys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gupta-piyush19 thanks :-) looks great in general. Only a few suggestions regarding the type naming and logs:
…177-add-hiddenfields-to-app-website-surveys
…177-add-hiddenfields-to-app-website-surveys
What does this PR do?
Adds hidden fields to app & website surveys.
Fixes
https://github.com/formbricks/internal/issues/177
How should this be tested?
formbricks.track
method to pass the hidden fields(inside properties) to the survey response.Checklist
Required
pnpm build
console.logs
git pull origin main
Appreciated