feat(anvil): --disable-tracing
#7445
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Mar 20, 2024
mattsse
requested changes
Mar 20, 2024
Comment on lines
+288
to
+293
| let mut inspector = Inspector::default(); | ||
| if !self.disable_tracing { | ||
| inspector = inspector.with_tracing(); | ||
| if self.enable_steps_tracing { | ||
| inspector = inspector.with_steps_tracing(); | ||
| } |
There was a problem hiding this comment.
we can leave the setup as is, but if tracing is disabled we need to change this:
foundry_evm::utils::new_evm_with_inspector(&mut *self.db, env, &mut inspector);
to evm setup without inspector, which is always faster than with any inspector
mattsse
requested changes
Mar 22, 2024
Comment on lines
+303
to
+311
| match evm.transact_commit() { | ||
| Ok(exec_result) => exec_result, | ||
| Err(err) => { | ||
| warn!(target: "backend", "[{:?}] failed to execute: {:?}", transaction.hash(), err); | ||
| match err { | ||
| EVMError::Database(err) => { | ||
| return Some(TransactionExecutionOutcome::DatabaseError( | ||
| transaction, | ||
| err, |
There was a problem hiding this comment.
I think we don't need the duplication here if we make the if else block return the result?
There was a problem hiding this comment.
The issue was building the evm with different types, one with an inspector and one without.
There was a problem hiding this comment.
I think we don't need the duplication here if we make the if else block return the result?
@mattsse The if else block already returns the exec_result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#7442
Solution
Add CLI arg
--disable-tracingto disable all tx tracing in anvil. Default value isfalse.