feat(cast): wallet keystore decrypting #7893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
May 8, 2024
rplusq
force-pushed
the
feat(cast)/wallet-decrypt-keystore
branch
from
2cba6a3
to
0a65341
Compare
|
Fixing clippy failing... |
rplusq
force-pushed
the
feat(cast)/wallet-decrypt-keystore
branch
from
0a65341
to
f4ef8ec
Compare
|
Ready for review @mattsse |
Evalir
reviewed
May 10, 2024
|
Fixed @Evalir |
mattsse
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After integrating
cast wallet importand using it for a while, some users might want to get the private key for an account back through decryption of the keystone, so we're just making it easy for them in the same cli they created the keystore.Solution
Added an extra command
DecryptKeystoreto theWalletSubcommandsenum, alongside the implementation where we verify the file exists, prompt for the password (they can also send it in clear text from the cli call if they wish to), decrypt the keystore to instantiate aLocalWalletand then make it an alloyB256so it formats properly in the print.