Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add hashmasks #14

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feature/add hashmasks #14

wants to merge 3 commits into from

Conversation

Tibike6
Copy link
Collaborator

@Tibike6 Tibike6 commented Feb 8, 2021

  1. I have fixed the problems and the typo from KnownOrigin.
  2. I have added Hashmasks to the subgraph
    One problem is that they do not implement IERC721Metadata (no tokenURI), so that the data is not in the blockchain. But they are available on the website. Since there are only 16384 in total I use the static ipfs links from there. What do you think?

@frostiq frostiq changed the base branch from master to erc1155-semifungibility-support February 20, 2021 19:43
@frostiq frostiq changed the base branch from erc1155-semifungibility-support to master February 20, 2021 19:43
@frostiq frostiq changed the base branch from master to known-origin-fix February 20, 2021 19:48
@frostiq frostiq changed the base branch from known-origin-fix to master February 20, 2021 19:48
@frostiq
Copy link
Owner

frostiq commented Feb 20, 2021

Thank you @Tibike6!
I've moved the fix for the KnownOrigin to a separate branch #16 for the sake of clarity

@frostiq
Copy link
Owner

frostiq commented Feb 20, 2021

I'll resolve the merge conflicts that occurred after the separation

@frostiq frostiq changed the base branch from master to known-origin-fix February 20, 2021 20:01
@frostiq frostiq changed the base branch from known-origin-fix to master February 20, 2021 20:01
@frostiq
Copy link
Owner

frostiq commented Feb 20, 2021

@Tibike6, yeah this should work, as there is no other option
Can I ask you to move this array to a separate hashmask-ipfs-uri.json file and just import it in the mappings?

@frostiq
Copy link
Owner

frostiq commented Feb 20, 2021

Also I didn’t get the relation between token ID and IPFS URI, could you please tell me more about how you created this array of URIs?
I've looked at hashmask list and it seems that the order is different there, but I guess that index is not the same as token id, right?

@Tibike6
Copy link
Collaborator Author

Tibike6 commented Mar 1, 2021

Also I didn’t get the relation between token ID and IPFS URI, could you please tell me more about how you created this array of URIs?
I've looked at hashmask list and it seems that the order is different there, but I guess that index is not the same as token id, right?

The data is a bit hidden. Main page => Record and Proof => https://www.thehashmasks.com/provenance.html

@Tibike6
Copy link
Collaborator Author

Tibike6 commented Mar 1, 2021

@Tibike6, yeah this should work, as there is no other option
Can I ask you to move this array to a separate hashmask-ipfs-uri.json file and just import it in the mappings?

I will try it. I hope it works in AssemblyScript

Repository owner deleted a comment from DKudleichuk Feb 1, 2024
Repository owner deleted a comment from officialarmannqureshi Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants