Skip to content
This repository has been archived by the owner on Jun 23, 2023. It is now read-only.

Send readonly macaroon along with lndconnect urls #81

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Send readonly macaroon along with lndconnect urls #81

wants to merge 2 commits into from

Conversation

junderw
Copy link

@junderw junderw commented Mar 6, 2021

Needed for Joule connection

@junderw junderw mentioned this pull request Mar 6, 2021
Open
louneskmt
louneskmt reviewed Mar 6, 2021
View reviewed changes
Copy link
Contributor

@louneskmt louneskmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @junderw!

Seems good to me. To keep consistency, maybe we can rename macaroon to macaroonAdmin? Or name these adminMacaroon and readOnlyMacaroon?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@louneskmt louneskmt louneskmt left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@junderw @louneskmt