This repository has been archived by the owner on Sep 18, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
Add more robust check for locked wallet #88
Open
JVillella
wants to merge
1
commit into
getumbrel:master
Choose a base branch
from
JVillella:support-lnd-0.13-locked-wallet-error
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add more robust check for locked wallet #88
JVillella
wants to merge
1
commit into
getumbrel:master
from
JVillella:support-lnd-0.13-locked-wallet-error
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronDewes
approved these changes
May 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, @JVillella! Have you sucessfully tested this?
Yep, been running locally for a few days now. |
Thanks so much for this @JVillell! So this isn't an immediate issue but will effect LND v0.13.0 once released, right? |
It's a fix needed for LND 0.13, that's right - but it's backwards compatible. |
AaronDewes
suggested changes
Jun 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
To not do that, they would need to fork/modify Umbrel, which Umbrel doesn't need to care about in my opinion. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been testing the latest LND w/ Umbra and have found it is doesn't try to unlock the wallet due to a faulty is locked check. This should be more robust from looking at the LND code.