Replace _glfwKeySym2Unicode with xkb_keysym_to_utf{8,32}
#2444
+25
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalSpook
commented
Dec 10, 2023
| // size, because we know it won't use more than 5 bytes. | ||
| // | ||
| // See: https://github.com/xkbcommon/libxkbcommon/issues/418 | ||
| if (xkb_keysym_to_utf8(keysyms[0], _glfw.wl.keynames[key], 7) <= 0) |
There was a problem hiding this comment.
I'd especially like comments on if this is okay.
libxkbcommon already provides functions to convert keysyms to codepoints and UTF-8. The library has offered these functions since 0.5.0 (https://xkbcommon.org/doc/0.5.0/group__keysyms.html), so using them won't cause any compatibility problems.
LocalSpook
force-pushed
the
xkb-utf-functions
branch
from
838f007
to
af9bfbf
Compare
LocalSpook
changed the title
_glfwKeySym2Unicode() with xkb_keysym_to_utf{8,32}()_glfwKeySym2Unicode with xkb_keysym_to_utf{8,32} on Wayland
elmindreda
changed the title
_glfwKeySym2Unicode with xkb_keysym_to_utf{8,32} on Wayland_glfwKeySym2Unicode with xkb_keysym_to_utf{8,32}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libxkbcommon already provides functions to convert keysyms to codepoints and UTF-8. The library has offered these functions since 0.5.0 (https://xkbcommon.org/doc/0.5.0/group__keysyms.html), so using them shouldn't cause any compatibility problems.