Joystick button, axis, and hat callbacks, and gamepad state callback. #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows using GLFW joysticks in an event based manner. For the joysticks, this was done by adding the callbacks and then calling them in the shared code in input.c. For the gamepads, a new shared function is called whenever the joystick's state changes. However the gamepad state callback is only called if the joystick is mapped to a gamepad.
Only calculate the joystick ID when the event callback is actually called.
…r joystick polling to make waitEvents return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been something that I've seen a lot of people requesting get added, and multiple years ago there was a PR made that was never merged in, #1590, that has some merge conflicts at the moment.
The original creator of that pull request doesn't seem to be active and there hasn't been any updates on it since Oct 22, 2022, and I would make this an addition to the original PR for this, but as there hasn't been much activity from the creator of that original pull request, and the person who updated it in October 2022 to resolve conflicts with the merge then, I'm not sure if a pull request would go through over there. All I did was resolve the current merge conflicts for this feature to be added, and wrote some (admittedly not great) documentation for the feature.
This adds in callback functions for joystick buttons (glfwSetJoystickButtonCallback), joystick axes (glfwSetJoystickAxisCallback), joystick hats (glfwSetJoystickHatCallback), and gamepad state (glfwSetGamepadStateCallback), and I hope that this finally gets this feature merged in because it's definitely going to be a useful addition.