Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify is_polygon_clockwise() coordinate system #92154

Merged
merged 1 commit into from
May 21, 2024

Conversation

lawnjelly
Copy link
Member

@lawnjelly lawnjelly commented May 20, 2024

The function assumes a normal Cartesian coordinate system.

Fixes #49716

Notes

  • Alternative would be to add a parameter to do the flip as in Add handedness enum for is_polygon_clockwise #89635, but that may be controversial, and is taking a while to be decided on, so this doc change will do the job either as the final solution, or until we decide on another solution.

@AThousandShips AThousandShips added enhancement cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels May 20, 2024
@AThousandShips
Copy link
Member

AThousandShips commented May 20, 2024

Will likely be needed for older versions regardless of adding a handedness option down the line, unless it can be considered safe for cherry picking (and likely won't get into 4.3 anyway)

core/math/geometry_2d.h Outdated Show resolved Hide resolved
The function assumes a normal Cartesian coordinate system.
@akien-mga akien-mga merged commit dcc7cb0 into godotengine:master May 21, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@lawnjelly lawnjelly deleted the is_polygon_clockwise_doc branch May 21, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geometry.is_polygon_clockwise seems to return the opposite of expected results
3 participants