Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to Dockerfile #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes to Dockerfile #10

wants to merge 2 commits into from

Commits on Apr 27, 2021

  1. Fixes to Dockerfile 

    * Install NodeJS 14 - The current recommended version. The old script is depreciated.

* Run `useradd` instead of `adduser` - Removes some error messages.

* Switch from `pm2 start` script to `pm2-runtime` command. - This is the recommended way to run pm2 in docker. It also stops us from crashing when the app name changes and the log file is missing,
    @MysticRyuujin
    MysticRyuujin committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    24d9169 View commit details
    Browse the repository at this point in the history

  2. Switch to Alpine 

    In an effort to more align with goerli#3 goals I switched to node:14-alpine - but I'm not sure if modification of app.json to passing env variables to docker is more or less preferred so here's another option.
    @MysticRyuujin
    MysticRyuujin committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    d7c2fa6 View commit details
    Browse the repository at this point in the history