Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: Use of alpine, pass in env vars and use pm2-runtime #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jleeh
Copy link

@jleeh jleeh commented Apr 12, 2019

Also:

  • Remove of envs completely from the app.json file. This is due to them having precedent over passed in environment variables and defaults are already set in lib/node.js
  • Use of the emit instance function for sending the hello/login message so errors are shown on failure and the message can be traced in the logs
  • Readme changes to better instruct any users

Docker refactor wins:

  • With the use of the node alpine image, size is cut down from 278MB to 53MB.
  • Using pm2-runtime with no daemon mode allows the entrypoint to be a pm2 command which stops the container if the client quits, rather than forever running just with tail -f even if the client exits.

Please also rectify #2 so we can get the correct automated Docker hub builds.

MysticRyuujin added a commit to MysticRyuujin/ethstats-client that referenced this pull request Apr 27, 2021
In an effort to more align with goerli#3 goals I switched to node:14-alpine - but I'm not sure if modification of app.json to passing env variables to docker is more or less preferred so here's another option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants