Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flush pending writes before suspend #10797

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Flush pending writes before suspend #10797

merged 3 commits into from
Jun 5, 2024

Conversation

PotatoesFall
Copy link
Contributor

@PotatoesFall PotatoesFall commented May 20, 2024 •
edited by the-mikedavis

Fixes #10765

Original MR for this issue: #10788

@PotatoesFall
Copy link
Contributor Author

PotatoesFall commented May 20, 2024 •
edited

testing

I tested this code change by editing the goimports tool (which is run when saving .go files and caused my issues in the first place), adding a 3 second sleep.

With the new changes and the above , hitting C-z directly after triggering a save using space-W, :w or :wa, helix pauses for the aforementioned 3 seconds, write the file, and then suspends.

@PotatoesFall PotatoesFall mentioned this pull request May 20, 2024
Closed
kirawi
kirawi reviewed May 20, 2024
View reviewed changes
helix-term/src/commands.rs Outdated Show resolved Hide resolved
@PotatoesFall @kirawi
review suggestion
1e3c2ff 
Co-authored-by: Kirawi <67773714+kirawi@users.noreply.github.com>
pascalkuthe
pascalkuthe previously approved these changes May 20, 2024
View reviewed changes
@kirawi kirawi added C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much A-command Area: Commands S-waiting-on-review Status: Awaiting review from a maintainer. labels May 21, 2024
the-mikedavis
the-mikedavis requested changes Jun 3, 2024
View reviewed changes
helix-term/src/commands.rs Outdated Show resolved Hide resolved
helix-term/src/commands.rs Outdated Show resolved Hide resolved
@the-mikedavis the-mikedavis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from a maintainer. labels Jun 3, 2024
@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 5, 2024
@pascalkuthe pascalkuthe merged commit c39cde8 into helix-editor:master Jun 5, 2024
6 checks passed
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
@PotatoesFall @kirawi @Vulpesx
Flush pending writes before suspend (helix-editor#10797)
461b98f 
* flush saves before suspending

* review suggestion

Co-authored-by: Kirawi <67773714+kirawi@users.noreply.github.com>

* review changes

---------

Co-authored-by: PotatoesFall <martyk@tuta.io>
Co-authored-by: Kirawi <67773714+kirawi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poliorcetics poliorcetics poliorcetics left review comments

@kirawi kirawi kirawi left review comments

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@pascalkuthe pascalkuthe pascalkuthe approved these changes

Assignees
No one assigned
Labels
A-command Area: Commands C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Writes are interrupted when suspending
5 participants
@PotatoesFall @poliorcetics @the-mikedavis @pascalkuthe @kirawi