Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hdi,hdk): align 'mock' and 'test_utils' features #1548

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

feat(hdi,hdk): align 'mock' and 'test_utils' features #1548

wants to merge 17 commits into from
+13 −3

Conversation

steveej
Copy link
Member

@steveej steveej commented Sep 1, 2022 •
edited

Summary

TODO:

  • CHANGELOG(s) updated with appropriate info
  • Just before pressing the merge button, ensure new entries to CHANGELOG(s) are still under the UNRELEASED heading

@steveej steveej changed the title [WIP] feat(hdi,hdk): align 'mock' and 'test_utils' features feat(hdi,hdk): align 'mock' and 'test_utils' features Sep 20, 2022
@steveej steveej marked this pull request as ready for review December 14, 2022 16:01
@steveej steveej requested a review from a team October 31, 2023 10:30
steveej
steveej commented Nov 1, 2023
View reviewed changes
crates/hdk/Cargo.toml Outdated Show resolved Hide resolved
@maackle
Copy link
Member

maackle commented Dec 5, 2023

I'm going through my old neglected notifications and this came up, @steveej is this something we want to merge still?

@steveej
Copy link
Member Author

steveej commented Dec 5, 2023

is this something we want to merge still?

yes, i think it's required for mocking the HDI in app validation tests.

@github-actions GitHub Actions
Copy link
Contributor

This item has been open for 30 days with no activity.

@github-actions github-actions bot added the stale This issue may be outdated, but we can revive it if it ever becomes relevant again label Jan 15, 2024
@steveej steveej removed the stale This issue may be outdated, but we can revive it if it ever becomes relevant again label Jan 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

This item has been open for 30 days with no activity.

@github-actions github-actions bot added the stale This issue may be outdated, but we can revive it if it ever becomes relevant again label Feb 25, 2024
@github-actions github-actions bot removed the stale This issue may be outdated, but we can revive it if it ever becomes relevant again label Mar 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2024

This item has been open for 30 days with no activity.

@github-actions github-actions bot added the stale This issue may be outdated, but we can revive it if it ever becomes relevant again label Apr 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

This item has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this Apr 22, 2024
@steveej steveej reopened this Apr 23, 2024
@steveej steveej added permanent Exempt this item from being marked stale and closed. and removed stale This issue may be outdated, but we can revive it if it ever becomes relevant again labels Apr 23, 2024
@steveej steveej self-assigned this Apr 23, 2024
@thedavidmeister
Copy link
Contributor

i'm gonna unsubscribe from this, it's really old

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jost-s jost-s jost-s approved these changes

@thedavidmeister thedavidmeister thedavidmeister approved these changes

Assignees

@steveej steveej

Labels
permanent Exempt this item from being marked stale and closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@steveej @maackle @thedavidmeister @jost-s