Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pw_hash_strength keystore config #3391

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

add pw_hash_strength keystore config #3391

wants to merge 4 commits into from

Conversation

neonphog
Copy link
Contributor

Summary

The underlying concern in holochain/lair#120 is startup time on mobile. This PR addresses that concern by providing a holochain configuration option to lower the password hashing strength employed by lair keystore.

It should now be possible to provide a conductor config like:

keystore:
  type: lair_server_in_proc
  pw_hash_strength: interactive

In my testing on my laptop, the default "Moderate" takes ~12 seconds to start, while "Interactive" takes ~2s.

TODO:

  • CHANGELOG(s) updated with appropriate info
  • Just before pressing the merge button, ensure new entries to CHANGELOG(s) are still under the UNRELEASED heading

@neonphog neonphog mentioned this pull request Feb 29, 2024
Open
@neonphog neonphog self-assigned this Mar 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2024

This item has been open for 30 days with no activity.

@github-actions github-actions bot added the stale This issue may be outdated, but we can revive it if it ever becomes relevant again label Apr 8, 2024
@abe-njama abe-njama removed the stale This issue may be outdated, but we can revive it if it ever becomes relevant again label Apr 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024

This item has been open for 30 days with no activity.

@github-actions github-actions bot added the stale This issue may be outdated, but we can revive it if it ever becomes relevant again label May 9, 2024
@neonphog neonphog removed the stale This issue may be outdated, but we can revive it if it ever becomes relevant again label May 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 9, 2024

This item has been open for 30 days with no activity.

@github-actions github-actions bot added the stale This issue may be outdated, but we can revive it if it ever becomes relevant again label Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@neonphog neonphog

Labels
stale This issue may be outdated, but we can revive it if it ever becomes relevant again
Projects
Holochain Core
Status: Ready
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@neonphog @abe-njama