Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment: Use release profile for CI tests #3574

Closed
wants to merge 5 commits into from
Closed

Conversation

maackle
Copy link
Member

@maackle maackle commented Apr 7, 2024

Summary

We were using a dev profile for building workspace crates, and a release-ish profile for all other deps. Let's see what it looks like to use release for everything.

TODO:

  • CHANGELOGs updated with appropriate info

@maackle maackle changed the title Use release profile for CI tests Experiment: Use release profile for CI tests Apr 7, 2024
@ThetaSinner
Copy link
Contributor

Looks like we have a test depending on being in debug mode? :D

Otherwise though this looks to me like it should work, based on a read through the holochain.nix module which uses this. Seems like a good idea unless there was another reason to have test deps build in debug mode

@maackle
Copy link
Member Author

maackle commented Apr 8, 2024

Yes, due to an expectation of debug_assert! causing a panic. I think our use of debug_assert is appropriate and should be included in CI. I enabled debug in the profile for workspace deps so let's see how that looks in the CI run.

@maackle
Copy link
Member Author

maackle commented Apr 17, 2024

The CI process consistently gets killed during compilation. My guess is the runner just can't/won't handle the load. We could loop back on this some time, but I'm going to consider the experiment concluded for now. Let's let stalebot close this.

Copy link
Contributor

This item has been open for 30 days with no activity.

@github-actions github-actions bot added the stale This issue may be outdated, but we can revive it if it ever becomes relevant again label May 18, 2024
Copy link
Contributor

github-actions bot commented Jun 1, 2024

This item has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale This issue may be outdated, but we can revive it if it ever becomes relevant again
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants