Update scaffolding bats integration tests #3761
Conversation
c12i
force-pushed
the
update-scaffolding-bats-integration-tests
branch
from
78750ae
to
edadba1
Compare
c12i
force-pushed
the
update-scaffolding-bats-integration-tests
branch
from
edadba1
to
fc9c6b5
Compare
c12i
force-pushed
the
update-scaffolding-bats-integration-tests
branch
from
bafe211
to
f58cfa6
Compare
|
It appears that this function call from here is resulting in a os error: |
|
@ThetaSinner and @steveej, running into two issues here. It appears that adding |
| @@ -18,5 +18,24 @@ teardown() { | |||
|
|
|||
| @test "expected scaffold an example to succeed" { | |||
| set -e | |||
| hc scaffold example forum -t vue | |||
There was a problem hiding this comment.
looks like this has been failing internally all along and it exitted 0 anyway.
There was a problem hiding this comment.
@c12i i think this needs to be fixed in scaffolding. are you going to take it from here or should i create an issue?
There was a problem hiding this comment.
Thanks for catching this, I know what the issue is, the arguments are a little different with different scaffolding versions. I can look into how I can fix this.
| setup_and_build_hello_world() { | ||
| print_version | ||
|
|
||
| hc-scaffold example hello-world |
There was a problem hiding this comment.
ideally we'd know about the failure here, see my previous comment
There was a problem hiding this comment.
using strace i can see that the problem is a missing nix binary in the test, and after adding that missing internet access. we're going to have to rework the holonix integration test derivation to make it work. i'm looking into our options right now.
steveej
added
bug
Summary
TODO: