SBD Integration #3842
Merged
SBD Integration #3842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonphog
added
the
NO-MERGE (dependency)
neonphog
commented
May 17, 2024
neonphog
commented
May 17, 2024
neonphog
changed the title
ThetaSinner
approved these changes
May 23, 2024
neonphog
removed
the
NO-MERGE (dependency)
pdaoust
requested changes
May 30, 2024
| //! ## Use the holo-provided default production bootstrap server. | ||
| //! bootstrap_service: https://bootstrap.holo.host | ||
| //! | ||
| //! ## [deprecated] Please just include this in your config file for now. |
There was a problem hiding this comment.
@jost-s notes that this isn't deprecated and is still required.
There was a problem hiding this comment.
Suggested change
| //! ## [deprecated] Please just include this in your config file for now. | |
| //! ## This currently has no effect on functionality but is required. Please just include as-is for now. |
There was a problem hiding this comment.
Let me know if that change works : )
| //! | ||
| //! ## Setup a specific network configuration.. | ||
| //! transport_pool: | ||
| //! ## use webrtc |
There was a problem hiding this comment.
Suggested change
| //! ## use webrtc | |
| //! ## Use WebRTC, which is the only option for now. |
Is this the only option? If not, just accept the capitalisation fixes.
There was a problem hiding this comment.
It's effectively the only option, so it makes sense to say that here.
Co-authored-by: Paul d'Aoust <paul.daoust@holo.host>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEPENDS ON:
TODO: