Warrants pt 3 -- authoring and integrating warrants #3875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonphog
reviewed
Jun 6, 2024
neonphog
reviewed
Jun 6, 2024
neonphog
reviewed
Jun 6, 2024
neonphog
reviewed
Jun 6, 2024
neonphog
reviewed
Jun 6, 2024
neonphog
reviewed
Jun 6, 2024
jost-s
reviewed
Jun 8, 2024
| workspace | ||
| .authored_db | ||
| .write_async(move |txn| { | ||
| warn!("Inserting warrant op"); |
There was a problem hiding this comment.
I suggest to add more info to this warning. I'd actually merge it with the one below and output the op that was rejected and the warrant op.
jost-s
reviewed
Jun 8, 2024
| assert_eq!(warrants.len(), 1); | ||
| }); | ||
|
|
||
| // TODO: ensure that bob blocked alice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #3639
There are some significant changes to the way the way the database is used.
DhtOp.typefield.DhtOp.action_hashfield can also contain a WarrantHash.It's all a bit messy, but was done in the spirit of minimal effort and change.
TODO: