Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Monzo config reauth #117726

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

Add Monzo config reauth #117726

wants to merge 11 commits into from

Conversation

JakeMartin-ICL
Copy link
Contributor

@JakeMartin-ICL JakeMartin-ICL commented May 19, 2024 •
edited

Proposed change

Added reauth config flow to the Monzo integration.

Dependency bump: #117730

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@JakeMartin-ICL JakeMartin-ICL force-pushed the monzo-integration-add-config-reauth branch from 87e565a to 0063b5d Compare May 19, 2024 12:18
@JakeMartin-ICL JakeMartin-ICL mentioned this pull request May 19, 2024
Merged
20 tasks
@JakeMartin-ICL JakeMartin-ICL force-pushed the monzo-integration-add-config-reauth branch from aadc966 to 9c0eedc Compare May 19, 2024 13:54
@JakeMartin-ICL JakeMartin-ICL force-pushed the monzo-integration-add-config-reauth branch from 4417dc3 to 79b73c2 Compare May 19, 2024 15:17
@MartinHjelmare MartinHjelmare changed the title Monzo integration: add config reauth Add Monzo config reauth May 19, 2024
allenporter
allenporter reviewed May 21, 2024
View reviewed changes
Copy link
Contributor

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, one minor test file suggestion.

@allenporter
Copy link
Contributor

Ok, to be clear just telling you what the norms are for this type of test in nearly every other integration.

@JakeMartin-ICL JakeMartin-ICL force-pushed the monzo-integration-add-config-reauth branch from 79b73c2 to 9a7b5bb Compare May 28, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allenporter allenporter allenporter left review comments

@joostlek joostlek Awaiting requested review from joostlek

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
by-code-owner cla-signed has-tests integration: monzo new-feature Quality Scale: No score
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JakeMartin-ICL @allenporter @joostlek