Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect incorrect exception in forwarded platforms #117754

Merged
merged 6 commits into from
May 21, 2024
Merged

Detect incorrect exception in forwarded platforms #117754

merged 6 commits into from
May 21, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 20, 2024 •
edited

Proposed change

If an integration raises ConfigEntryError/ConfigEntryAuthFailed/ConfigEntryAuthFailed in a forwarded platform, give a better error message.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco
Detect incorrect exception in forwarded platforms
32e2821 
If an integration raises ConfigEntryError/ConfigEntryAuthFailed/ConfigEntryAuthFailed
in a forwarded platform it would affect the state of the config entry and cause it to
process unloads and setup retries in while the other platforms continued to setup
@bdraco
Detect incorrect exception in forwarded platforms
02c075e 
If an integration raises ConfigEntryError/ConfigEntryAuthFailed/ConfigEntryAuthFailed
in a forwarded platform it would affect the state of the config entry and cause it to
process unloads and setup retries in while the other platforms continued to setup
@bdraco
Merge branch 'dev' into setup_retry_forwarded_platform
d278b85
bdraco and others added 3 commits May 20, 2024 10:02
@bdraco @balloob
Update homeassistant/config_entries.py
f1325cc 
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
@bdraco
adjust
c094433
@bdraco
fix
ff61e17
@bdraco
Copy link
Member Author

bdraco commented May 20, 2024

It turns out the exception can't get high enough in the stack to actually case a problem. I'm going to improve the error message instead.

@bdraco bdraco marked this pull request as ready for review May 20, 2024 20:37
@bdraco bdraco requested a review from a team as a code owner May 20, 2024 20:37
@balloob balloob merged commit 7714f80 into dev May 21, 2024
38 checks passed
@balloob balloob deleted the setup_retry_forwarded_platform branch May 21, 2024 00:02
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cla-signed code-quality core small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bdraco @balloob