-
Notifications
You must be signed in to change notification settings - Fork 8.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Changes regarding dealing with pointers to ed25519 keys versus the values. This is a concern because golang generally deals with ed25519 keys by value. This causes a difference between the default way to deal with ecdsa keys (pointers) and ed25519 ones (values). As I implemented, the ed25519 keys storing and parsing follow the general rules: 1) Ed25519 keys are parsed from files as values (ed25519.PrivateKey or ed25519.PublicKey) but are eventually converted to pointers to fit the structs ed25519PrivateKey and ed25519PublicKey. 2) To store ed25519 keys in the fileks, they are dealt with as pointers until the marshalling method, from the x509 golang library. This fits test cases for storing "nil" keys, that would cause panic if the key were treated as value. Fileks test cases for ed25519 were added.
- Loading branch information
Showing
4 changed files
with
57 additions
and
47 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters