Remove usage of fmt.Errorf #4467
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patchset uses the errors pkg to follow the guideline at https://hyperledger-fabric.readthedocs.io/en/latest/error-handling.html Change-Id: I36eaac1b429c69195e4af1bb5bb25fc1a2578168 Signed-off-by: Baohua Yang <yangbaohua@gmail.com> Signed-off-by: Baohua Yang <baohua.yang@oracle.com>
|
I'm not sure these guidelines are still up-to-date, since github.com/pkg/errors has been archived 2 years ago and is effectively a dead project. @denyeart wdyt? |
|
@ale-linux I made an initial comment over at #4461 (comment). I've also opened issue #4468 with more background so that we can discuss a plan in more detail. My suggestion would be to not make these error handling changes until we've got some more opinions gathered in #4468. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patchset uses the errors pkg to follow the guideline at
https://hyperledger-fabric.readthedocs.io/en/latest/error-handling.html
Change-Id: I36eaac1b429c69195e4af1bb5bb25fc1a2578168
Type of change
Description
Remove the usage of fmt.Errorf. Follow the official guideline to change
to the errors package.
Additional details
N/A
Related issues
N/A
Release Note
N/A