Allow error to be wrapped #4689
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change output fmt from %s to %w, which is supported by errors and fmt to wrap error. Change-Id: I3620094d9aece9151bf5dd08005673c2610aa041 Signed-off-by: Baohua Yang <yangbaohua@gmail.com> Signed-off-by: Baohua Yang <baohua.yang@oracle.com>
|
My opinion is that we shouldn't be changing error handling as a series of one-off pull requests. In this case the caller of the function doesn't have any need to unwrap the error so I'm not understanding how wrapping adds value here. If you think there is value in changing error handling practices in general, let's have that discussion in the error handling issue and come up with an overall plan for rolling the changes into the codebase. This should include discussion of how callers should be updated to take advantage of new proposed practices. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I3620094d9aece9151bf5dd08005673c2610aa041
Type of change
Description
Change output fmt from %s to %w, which is supported by errors and fmt
to wrap error.
Additional details
N/A
Related issues
N/A
Release Note
N/A