Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove global-level endpoints from channel config - mid version - w.i.p. #4800

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

MayRosenbaum
Copy link
Contributor

Type of change

config update

Description

This PR aims to block the option to specify global-level endpoints and enforce that endpoints per org are defined.
Integration tests + unit tests were updated.

@MayRosenbaum MayRosenbaum requested a review from a team as a code owner April 7, 2024 08:52
@MayRosenbaum MayRosenbaum force-pushed the Remove_global_level_endpoints_from_the_channel_config_mid_version branch from ac2ae45 to 5c1219a Compare April 7, 2024 08:57
@MayRosenbaum MayRosenbaum force-pushed the Remove_global_level_endpoints_from_the_channel_config_mid_version branch 8 times, most recently from 88d22d3 to 37262c2 Compare April 17, 2024 12:45
@denyeart
Copy link
Contributor

@Mergifyio rebase

@denyeart denyeart force-pushed the Remove_global_level_endpoints_from_the_channel_config_mid_version branch from a5687d5 to 39068ab Compare April 18, 2024 14:04
Copy link

mergify bot commented Apr 18, 2024

rebase

✅ Branch has been successfully rebased

@yacovm
Copy link
Contributor

yacovm commented May 3, 2024

@MayRosenbaum which one is the relevant one? This one or #4778 ? Please close the other one.

@MayRosenbaum MayRosenbaum force-pushed the Remove_global_level_endpoints_from_the_channel_config_mid_version branch from 39068ab to 5cb9196 Compare May 5, 2024 12:04
@tock-ibm tock-ibm force-pushed the Remove_global_level_endpoints_from_the_channel_config_mid_version branch from 0a60cd2 to f8f280e Compare May 13, 2024 09:49
MayRosenbaum and others added 8 commits May 13, 2024 12:52
Signed-off-by: May Rosenbaum <mayro1595@gmail.com>
Signed-off-by: Yacov Manevich <yacov.manevich@ibm.com>
Signed-off-by: May Rosenbaum <mayro1595@gmail.com>
Signed-off-by: May Rosenbaum <mayro1595@gmail.com>
Signed-off-by: Yacov Manevich <yacov.manevich@ibm.com>
Signed-off-by: May Rosenbaum <mayro1595@gmail.com>
Signed-off-by: May Rosenbaum <mayro1595@gmail.com>
Signed-off-by: May Rosenbaum <mayro1595@gmail.com>
Signed-off-by: May Rosenbaum <mayro1595@gmail.com>
Signed-off-by: Yoav Tock <tock@il.ibm.com>
@tock-ibm tock-ibm force-pushed the Remove_global_level_endpoints_from_the_channel_config_mid_version branch from f8f280e to b0f238b Compare May 13, 2024 09:52
Signed-off-by: Yoav Tock <tock@il.ibm.com>
Signed-off-by: Yoav Tock <tock@il.ibm.com>
Signed-off-by: Yoav Tock <tock@il.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants