New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove global-level endpoints from channel config - mid version - w.i.p. #4800
Open
MayRosenbaum
wants to merge
11
commits into
hyperledger:main
Choose a base branch
from
MayRosenbaum:Remove_global_level_endpoints_from_the_channel_config_mid_version
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Remove global-level endpoints from channel config - mid version - w.i.p. #4800
MayRosenbaum
wants to merge
11
commits into
hyperledger:main
from
MayRosenbaum:Remove_global_level_endpoints_from_the_channel_config_mid_version
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MayRosenbaum
force-pushed
the
Remove_global_level_endpoints_from_the_channel_config_mid_version
branch
from
April 7, 2024 08:57
ac2ae45
to
5c1219a
Compare
MayRosenbaum
force-pushed
the
Remove_global_level_endpoints_from_the_channel_config_mid_version
branch
8 times, most recently
from
April 17, 2024 12:45
88d22d3
to
37262c2
Compare
@Mergifyio rebase |
denyeart
force-pushed
the
Remove_global_level_endpoints_from_the_channel_config_mid_version
branch
from
April 18, 2024 14:04
a5687d5
to
39068ab
Compare
✅ Branch has been successfully rebased |
@MayRosenbaum which one is the relevant one? This one or #4778 ? Please close the other one. |
MayRosenbaum
force-pushed
the
Remove_global_level_endpoints_from_the_channel_config_mid_version
branch
from
May 5, 2024 12:04
39068ab
to
5cb9196
Compare
tock-ibm
force-pushed
the
Remove_global_level_endpoints_from_the_channel_config_mid_version
branch
from
May 13, 2024 09:49
0a60cd2
to
f8f280e
Compare
Signed-off-by: May Rosenbaum <mayro1595@gmail.com> Signed-off-by: Yacov Manevich <yacov.manevich@ibm.com>
Signed-off-by: May Rosenbaum <mayro1595@gmail.com>
Signed-off-by: May Rosenbaum <mayro1595@gmail.com>
Signed-off-by: May Rosenbaum <mayro1595@gmail.com>
Signed-off-by: May Rosenbaum <mayro1595@gmail.com>
Signed-off-by: May Rosenbaum <mayro1595@gmail.com>
Signed-off-by: Yoav Tock <tock@il.ibm.com>
tock-ibm
force-pushed
the
Remove_global_level_endpoints_from_the_channel_config_mid_version
branch
from
May 13, 2024 09:52
f8f280e
to
b0f238b
Compare
Signed-off-by: Yoav Tock <tock@il.ibm.com>
Signed-off-by: Yoav Tock <tock@il.ibm.com>
Signed-off-by: Yoav Tock <tock@il.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
config update
Description
This PR aims to block the option to specify global-level endpoints and enforce that endpoints per org are defined.
Integration tests + unit tests were updated.