Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align jQuery.merge & push.apply calls #5298

Open
mgol opened this issue Jul 12, 2023 · 1 comment
Open

Align jQuery.merge & push.apply calls #5298

mgol opened this issue Jul 12, 2023 · 1 comment
Labels
Core
Milestone
4.1.0

Comments

@mgol
Copy link
Member

mgol commented Jul 12, 2023 •
edited

Description

We have a number jQuery.merge & push.apply calls that seem interchangeable in many cases. We should investigate their usage and perhaps align to one of them. If push.apply works fine, we could investigate simplifying the jQuery.merge implementation by leveraging it.

We used to have a comment about that in domManip.js but we should investigate all places.

When investigating, take #4320 into account.

Link to test case
@mgol mgol added the Core label Jul 12, 2023
@mgol mgol added this to the 4.1.0 milestone Jul 12, 2023
mgol added a commit to mgol/jquery that referenced this issue Jul 12, 2023
@mgol
Manipulation: Remove a TODO comment in favor of tracking in jquerygh-…
256c65f 
…5298

jquerygh-5298 is about analysing `push.apply` & `jQuery.merge` usage more
comprehensively.
@mgol mgol mentioned this issue Jul 12, 2023
Merged
@mgol mgol mentioned this issue Jul 21, 2023
Merged
2 tasks
@mgol
Copy link
Member Author

mgol commented Sep 7, 2023

More interesting context about the limits of push.apply in jquery/sizzle#403; some performance aspects are also addressed in a discussion there.

@mgol mgol mentioned this issue Sep 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Core
Milestone
4.1.0
Development

No branches or pull requests
1 participant
@mgol