Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Simplify code post browser support reduction #5296

Merged
merged 11 commits into from Sep 19, 2023
Merged

Core: Simplify code post browser support reduction #5296

merged 11 commits into from Sep 19, 2023

Conversation

mgol
Copy link
Member

@mgol mgol commented Jul 10, 2023

Summary

Checklist

@mgol mgol added the Core label Jul 10, 2023
@mgol mgol self-assigned this Jul 10, 2023
@mgol mgol marked this pull request as ready for review July 10, 2023 22:09
@mgol
Copy link
Member Author

mgol commented Jul 10, 2023

Size impact:

   raw     gz Compared to main @ 8be4c0e4f89d6c8f780e5937a0534921d8c7815e      
   -10     -3 dist/jquery.min.js                                               
    -6     -1 dist/jquery.slim.min.js                                          
   -10     -3 dist-module/jquery.module.min.js                                 
    -6      = dist-module/jquery.slim.module.min.js

@mgol
Manipulation: Remove a TODO comment in favor of tracking in jquerygh-…
256c65f 
…5298

jquerygh-5298 is about analysing `push.apply` & `jQuery.merge` usage more
comprehensively.
@mgol
Copy link
Member Author

mgol commented Jul 12, 2023

I removed a TODO comment about push.apply vs. jQuery.merge from domManip.js in favor of tracking in #5298. This will require more time so it makes sense to tackle this separately.

@mgol mgol merged commit 93ca49e into jquery:main Sep 19, 2023
13 checks passed
@mgol mgol deleted the docs-tests-cleanup branch September 19, 2023 22:54
@mgol mgol added this to the 4.0.0 milestone Sep 19, 2023
@mgol mgol removed the Needs review label Sep 19, 2023
@mgol mgol modified the milestones: 4.0.0, 3.7.2 Sep 19, 2023
mgol added a commit that referenced this pull request Sep 19, 2023
@mgol
Core: Simplify code post browser support reduction
6fe8869 
Summary of the changes:
* Tests: Remove legacy jQuery.cache & oldIE leftovers
* Tests: Reformat JavaScript in delegatetest.html
* Docs: "jQuery Foundation Projects" -> "jQuery Projects"
* Tests: Drop an unused localfile.html file (modern browsers don't support
  the `file:` protocol this way, there's no point in keeping the file around)
* Effects: Remove a redundant `!fn` check (`fn || !fn && easing` is equivalent
  to `fn || easing`; simplify the code)
* CSS: Explain the fallback to direct object access in curCSS better
* Tests: Deduplicate `jQuery.parseHTML` test titles
* Dimensions: Add a test for fractional values
* Tests: Fix a buggy WebKit regex

Closes gh-5296

(cherry picked from commit 93ca49e)
@mgol
Copy link
Member Author

mgol commented Sep 19, 2023

Landed on main in 93ca49e and, with a few exceptions, on 3.x-stable in 6fe8869.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmywil timmywil timmywil approved these changes

@gibson042 gibson042 gibson042 approved these changes

Assignees

@mgol mgol

Labels
Core
Milestone
3.7.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mgol @timmywil @gibson042