Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the chrome bug: https://bugs.chromium.org/p/chromium/issues/detai… #4318

Closed
wants to merge 2 commits into from

Conversation

Spazierenman
Copy link

…l?id=103583

Summary

Checklist

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Сергей Карцев seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

Copy link
Member

@gibson042 gibson042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, but our contribution guidelines and issue template specify the need to start with a bug report including a reduced test case, and the former also links to our style guide and explain the need to include unit tests (also a part of the pull request template that you encountered before opening this request).

And all that aside, fixing large array handling is the kind of thing we would want across the library, rather than limiting it to jQuery.map (cf. domManip, jQuery.makeArray, jQuery.proxy, appendTo, etc.).

@gibson042
Copy link
Member

I'm going to close this for now, but it can be reopened if you find a broader solution that doesn't excessively increase the size of jquery.min.js.gz (i.e., by more than the change itself is worth).

@mgol
Copy link
Member

mgol commented Mar 14, 2019

More discussion at #4320.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants