Skip to content

Commit

Permalink
Tests: Disable the ":lang respects escaped backslashes" test
Browse files Browse the repository at this point in the history
Firefox 114+ no longer match on backslashes in `:lang()`, even when escaped.
It is an intentional change as `:lang()` parameters are supposed to be valid
BCP 47 strings. Therefore, we won't attempt to patch it.
We'll keep this test here until other browsers match the behavior.

Ref jquery/jquery#5271
Ref jquery/jquery#5277
Ref https://bugzilla.mozilla.org/show_bug.cgi?id=1839747#c1
Ref w3c/csswg-drafts#8720 (comment)
  • Loading branch information
mgol committed Sep 7, 2023
1 parent 4194dc4 commit 2f1afae
Showing 1 changed file with 12 additions and 3 deletions.
15 changes: 12 additions & 3 deletions test/unit/selector.js
Expand Up @@ -1246,7 +1246,7 @@ QUnit.test( "pseudo - :target and :root", function( assert ) {
} );

QUnit.test( "pseudo - :lang", function( assert ) {
assert.expect( 105 );
assert.expect( 104 );

var docElem = document.documentElement,
docXmlLang = docElem.getAttribute( "xml:lang" ),
Expand Down Expand Up @@ -1319,8 +1319,17 @@ QUnit.test( "pseudo - :lang", function( assert ) {
anchor.parentNode.lang = "ara";
anchor.lang = "ara\\b";
assert.deepEqual( Sizzle( ":lang(ara\\b)", foo ), [], ":lang respects backslashes" );
assert.deepEqual( Sizzle( ":lang(ara\\\\b)", foo ), [ anchor ],
":lang respects escaped backslashes" );

// Support: Firefox 114+
// Firefox 114+ no longer match on backslashes in `:lang()`, even when escaped.
// It is an intentional change as `:lang()` parameters are supposed to be valid
// BCP 47 strings. Therefore, we won't attempt to patch it.
// We'll keep this test here until other browsers match the behavior.
// See https://bugzilla.mozilla.org/show_bug.cgi?id=1839747#c1
// See https://github.com/w3c/csswg-drafts/issues/8720#issuecomment-1509242961
// assert.deepEqual( Sizzle( ":lang(ara\\\\b)", foo ), [ anchor ],
// ":lang respects escaped backslashes" );

assert.throws( function() {
Sizzle.call( null, "#qunit-fixture:lang(c++)" );
}, function( e ) {
Expand Down

0 comments on commit 2f1afae

Please sign in to comment.