-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding tests for transactions v3 #1607
Conversation
@tdelabro I just updated the PR sir. |
@Gerson2102 the CI is failing |
In the code I'm seeing some tests related to strk and eth fees, i have to do something like that? Or is already tested? |
@Gerson2102 again there is commits that are not your is this PR. You should rebase your comment onto the head on the main branch. I don't know how you proceed but it make unreviewable, as I'm reviewing changes from other already merged PRs at the same time. I recommend you give a look to this: https://docs.gitlab.com/ee/topics/git/git_rebase.html |
63e1146
to
b4e7162
Compare
the CI is failing |
I'm working in this test:
I'm doing that test based in other test. I just want to declare the tx v3, and check if its working, but I'm getting an error in the assert_ok!(). I dont know if I'm doing something wrong here. the error:
The test I based it on:
|
@Gerson2102 |
In This is the code for the deploy test:
|
@Gerson2102 the test you added are failing |
Than you so much for ur guidance so far sir. Still working on it. |
This is the error that I'm getting on the last test in
|
I dont know which address should I use for the compiled class hash:
I put it different because i was looking at another test that was using different addresses. |
Now im getting an error related to the gas amount:
I dont know if i should increment it or something. |
@Gerson2102 yup, you should definitely increment it. Change the content of |
@tdelabro I think I'm done sir. I'm just trying to fix the CI issues. |
When i run this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly it seems you don't have the same version of prettier
[warn] docs/content/articles/cn/madara-beast-article.md I don't know how to fix those either. Prettier is supposed to do it |
@Gerson2102 I will try to pull it myself and run prettier on my computer and then push |
No worries, i already fixed it. |
Now all looks green :) |
GG @Gerson2102! You did it! Thanks a lot |
Adding some tests for txv3, some of them are not working.
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
Resolves: #1574
NOOther information
The tests that are supposed to fail are working properly. But those tests that have to success, are failing. Maybe I'm doing something wrong here, i dont think that is a coincidence.