added pallet test for InvokeTransaction::V0 #1608
Conversation
|
@tdelabro I've opened a PR here, I think you should be able to review here. Thank you. |
|
thanks for this pr @raizo07, I think the issue was about declare v0 tho. Also in this PR you modify an existing test instead of adding a new one. Please also update changelog. |
@EvolveArt Thank you for your comment. But from this link #1603 (comment) You can see that it is a different task I was asked to work on, of which I added the test. I'm open to further reviews. |
|
@raizo07, still working on it? |
Yes, I'll be sending the PR today. |
| new_test_ext::<MockRuntime>().execute_with(|| { | ||
| basic_test_setup(2); | ||
|
|
||
| let mut transaction = get_invoke_dummy(Starknet::chain_id(), NONCE_ZERO); |
There was a problem hiding this comment.
get_invoke_dummy will always return a TxV1. That what it is coded to do
There was a problem hiding this comment.
so you never enter if let starknet_api::transaction::InvokeTransaction::V0(tx)
and therefore you are execution a tx v1 here: assert_ok!(Starknet::invoke(RuntimeOrigin::none(), transaction));
|
@raizo07 this time the tests don't even compile. |
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
All the transaction tests in are
InvokeTransaction::V0Resolves: missing V0 tests.
What is the new behavior?
Does this introduce a breaking change?
Other information