Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add intial translation of the figures for the chapters of hashing, tree, and heap #1339

Merged
merged 3 commits into from
May 31, 2024

Conversation

krahets
Copy link
Owner

@krahets krahets commented May 4, 2024

If this pull request (PR) pertains to Chinese-to-English translation, please confirm that you have read the contribution guidelines and complete the checklist below:

  • This PR represents the translation of a single, complete document, or contains only bug fixes.
  • The translation accurately conveys the original meaning and intent of the Chinese version. If deviations exist, I have provided explanatory comments to clarify the reasons.

@krahets krahets added translation English translation documents documents-related labels May 4, 2024
@krahets krahets self-assigned this May 4, 2024
@krahets
Copy link
Owner Author

krahets commented May 4, 2024

Please review the translation based on the following aspects:

  1. Ensure the expression is authentic and accurate.
  2. Maintain consistency between the Chinese and English versions. (Balancing with point 1)
  3. Since English is significantly longer than Chinese, some of the content has been simplified, resulting in poorer consistency. Please only add comments if you think it's ambiguous.

In addition to content, please pay attention to the format:

  1. It is expected to use Roboto font for normal text and Roboto Mono for formulas and code. These may be prone to mistakes since they are set manually.
  2. The style and color of shapes and texts should be consistent between the two versions. (I made some color adjustments in the EN version to enhance readability, so please only report those that feel uncomfortable to you.)

Copy link
Contributor

@K3v123 K3v123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall the translations are accurate
its just the bold and colors again.

@krahets krahets changed the title Add intial translation of the figures for the chapters of hashing, tree, and graph Add intial translation of the figures for the chapters of hashing, tree, and heap May 31, 2024
@krahets krahets changed the base branch from base to main May 31, 2024 07:59
@krahets
Copy link
Owner Author

krahets commented May 31, 2024

Thanks for your thorough review! @K3v123, @pengchzn most of the comments have been addressed. A few comments remain unresolved for further discussion. Please let me know if there's anything else that needs fixing.

@krahets krahets merged commit 8b3e705 into main May 31, 2024
1 check passed
@krahets krahets deleted the dev_trans1 branch May 31, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documents documents-related translation English translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants