feat: implement poseidon transcript #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomTaehoonKim
requested review from
chokobole,
dongchangYoo,
Insun35,
Leegwangwoon and
lightscale-luke
TomTaehoonKim
commented
Oct 23, 2023
|
Could you add a reason for why you rename |
|
|
Could you update the commit body to the last commit? |
chokobole
reviewed
Oct 24, 2023
TomTaehoonKim
force-pushed
the
feat/implement-poseidon-transcript
branch
3 times, most recently
from
244b601
to
70f9bdc
Compare
|
|
chokobole
requested changes
Oct 25, 2023
TomTaehoonKim
force-pushed
the
feat/implement-poseidon-transcript
branch
2 times, most recently
from
d6334c4
to
7f28f5e
Compare
Halo2 uses a different config entry from the "default" config entries in arkworks, so renamed to `PoseidonConfigEntry`. See https://github.com/kroma-network/halo2/blob/7d0a36990452c8e7ebd600de258420781a9b7917/halo2_proofs/src/transcript/poseidon.rs#L28C31-L28C31
- Rename test - Use `TEST_F` instead of `TYPED_TEST` - Use `F` instead of `math::bls12_381::Fr`
TomTaehoonKim
force-pushed
the
feat/implement-poseidon-transcript
branch
from
7f28f5e
to
e905450
Compare
chokobole
reviewed
Oct 25, 2023
chokobole
reviewed
Oct 25, 2023
TomTaehoonKim
force-pushed
the
feat/implement-poseidon-transcript
branch
from
e905450
to
c6de27d
Compare
chokobole
force-pushed
the
feat/implement-poseidon-transcript
branch
from
c6de27d
to
36a9429
Compare
TomTaehoonKim
force-pushed
the
feat/implement-poseidon-transcript
branch
from
36a9429
to
8825d63
Compare
TomTaehoonKim
force-pushed
the
feat/implement-poseidon-transcript
branch
from
8825d63
to
b733f83
Compare
See [PoseidonRead](https://github.com/kroma-network/halo2/blob/7d0a36990452c8e7ebd600de258420781a9b7917/halo2_proofs/src/transcript/poseidon.rs#L12-L100), [PoseidonWrite](https://github.com/kroma-network/halo2/blob/7d0a36990452c8e7ebd600de258420781a9b7917/halo2_proofs/src/transcript/poseidon.rs#L102-L174), [Transcript](https://github.com/kroma-network/halo2/blob/7d0a36990452c8e7ebd600de258420781a9b7917/halo2_proofs/src/transcript.rs#L43-L63), [TranscriptRead](https://github.com/kroma-network/halo2/blob/7d0a36990452c8e7ebd600de258420781a9b7917/halo2_proofs/src/transcript.rs#L65-L73) and [TranscriptWirte](https://github.com/kroma-network/halo2/blob/7d0a36990452c8e7ebd600de258420781a9b7917/halo2_proofs/src/transcript.rs#L75-L83).
TomTaehoonKim
force-pushed
the
feat/implement-poseidon-transcript
branch
from
b733f83
to
abf97b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements Poseidon Transcript (Poseidon Read/Write) along with a base class Transcript (Transcript, Transcript Read/Write) which will later also be used implementing Sha256 Transcript.
Note that Halo2 Poseidon Sponge is implemented for two variants compared to Poseidon Sponge from arkworks.
For the halo2 rust implementation, see link