refac: improve pcs interface #225
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chokobole
force-pushed
the
refac/improve-pcs-interface
branch
from
089ad49
to
377692a
Compare
chokobole
force-pushed
the
refac/improve-pcs-interface
branch
from
377692a
to
08797eb
Compare
TomTaehoonKim
requested changes
Jan 10, 2024
| @@ -96,15 +93,28 @@ class TranscriptReaderImpl<Commitment, false> : public Transcript<Commitment> { | |||
| const base::Buffer& buffer() const { return buffer_; } | |||
|
|
|||
| // Read a |commitment| from the proof. Note that it also writes the | |||
| // |commitment| to the transcript by calling |WriteToTranscript()| internally. | |||
| // |value| to the transcript by calling |WriteToTranscript()| internally when | |||
There was a problem hiding this comment.
Suggested change
| // |value| to the transcript by calling |WriteToTranscript()| internally when | |
| // |commitment| to the transcript by calling |WriteToTranscript()| internally when |
| $$Commit(L) \to C$$ | ||
| $$Open(i) \to \pi$$ | ||
| $$Verify(R, \pi) \to true \space or \space false$$ | ||
| $$L\text{: the set of leaf, }i\text{: index of the leaf }R\text{: merkle root}$$ |
There was a problem hiding this comment.
Suggested change
| $$L\text{: the set of leaf, }i\text{: index of the leaf }R\text{: merkle root}$$ | |
| $$L\text{: the set of leaf, }i\text{: index of the leaf }R\text{: the merkle root}$$ |
This is needed by improving PCS interface.
This commit solves 2 problems. 1. `Transcript` was only able to handle field or curve point. Since proof and hash algorithm can take arbitrary types, this limitation is overcame. 2. The interfaces of `VectorCommitmentScheme` and `UnivariatePolynomialCommitmentScheme` are organized. When committing, the cases are divided into 3 cases. - non interactive: e.g, SHPlonk, MerkleTree - non interactive with random: e.g, Pedersen - interactive: e.g, FRI When opening, the cases are divided into 2 cases. - non interactive: e.g, MerkleTree - interactive: e.g, SHPlonk and FRI When verifying, the cases are divided into 2 cases. - both committing and opening is non interactive: e.g, MerkleTree - either committing or opening is interative: e.g, SHPlonk and FRI
chokobole
force-pushed
the
refac/improve-pcs-interface
branch
from
08797eb
to
5b9fadb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves 2 problems.
Transcriptwas only able to handle field or curve point.Since proof and hash algorithm can take arbitrary types, this limitation no longer exists.
The interfaces of
VectorCommitmentSchemeandUnivariatePolynomialCommitmentSchemeare organized.When committing, there are 3 cases:
When opening, there are 2 cases:
When verifying, there are 2 cases: