Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: implement fibonacci circuits #279

Merged
merged 5 commits into from May 20, 2024
Merged

test: implement fibonacci circuits #279

merged 5 commits into from May 20, 2024

Conversation

TomTaehoonKim
Copy link
Contributor

@TomTaehoonKim TomTaehoonKim commented Feb 5, 2024 •
edited by ashjeong

Description

This PR implements fibonacci circuits and tests for the circuits.

See here for the reference code.

This PR should be merged after #280 and #415.

Authored by @TomTaehoonKim & @ashjeong

@TomTaehoonKim TomTaehoonKim force-pushed the feat/implement-fibonacci-circuits branch 3 times, most recently from 9bfa2eb to fe1edc7 Compare February 6, 2024 03:23
@chokobole
Copy link
Contributor

fb7c81d Didn't we discuss using TYPED_TEST if circuit test data can be separated?

@TomTaehoonKim TomTaehoonKim changed the title feat: implement fibonacci circuits test: implement fibonacci circuits Feb 7, 2024
@ashjeong ashjeong force-pushed the feat/implement-fibonacci-circuits branch 4 times, most recently from 74f90ad to 8a84c27 Compare April 22, 2024 14:37
chokobole
chokobole reviewed Apr 23, 2024
View reviewed changes
tachyon/zk/plonk/halo2/BUILD.bazel Outdated Show resolved Hide resolved
tachyon/zk/plonk/examples/fibonacci/BUILD.bazel Outdated Show resolved Hide resolved
@ashjeong ashjeong marked this pull request as draft April 23, 2024 04:35
@ashjeong ashjeong force-pushed the feat/implement-fibonacci-circuits branch 5 times, most recently from a7c8971 to ea8cbd5 Compare May 14, 2024 06:04
@ashjeong ashjeong marked this pull request as ready for review May 14, 2024 06:45
@ashjeong ashjeong marked this pull request as draft May 16, 2024 07:37
@ashjeong ashjeong force-pushed the feat/implement-fibonacci-circuits branch 5 times, most recently from e26746d to 3e837be Compare May 17, 2024 05:12
@ashjeong ashjeong marked this pull request as ready for review May 17, 2024 05:13
@ashjeong ashjeong force-pushed the feat/implement-fibonacci-circuits branch from 3e837be to 3c91a44 Compare May 17, 2024 05:15
@ashjeong ashjeong force-pushed the feat/implement-fibonacci-circuits branch from 3c91a44 to 7ca4f0a Compare May 17, 2024 06:11
TomTaehoonKim
TomTaehoonKim commented May 17, 2024
View reviewed changes
Copy link
Contributor Author

@TomTaehoonKim TomTaehoonKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I can't leave review as approve since I'm the author lol.

ashjeong
ashjeong approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@ashjeong ashjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomTaehoonKim : LGTM

@ashjeong ashjeong requested a review from chokobole May 17, 2024 08:12
Insun35
Insun35 approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@Insun35 Insun35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chokobole
chokobole reviewed May 17, 2024
View reviewed changes
tachyon/zk/plonk/examples/circuit_test_type_traits.h Outdated Show resolved Hide resolved
tachyon/zk/plonk/examples/fibonacci/fibonacci1_circuit.h Outdated Show resolved Hide resolved
tachyon/zk/plonk/examples/fibonacci/fibonacci2_circuit.h Outdated Show resolved Hide resolved
tachyon/zk/plonk/examples/fibonacci/fibonacci1_circuit.h Outdated Show resolved Hide resolved
tachyon/zk/plonk/examples/fibonacci/fibonacci2_circuit.h Outdated Show resolved Hide resolved
tachyon/zk/plonk/examples/fibonacci/fibonacci1_circuit.h Outdated Show resolved Hide resolved
tachyon/zk/plonk/examples/fibonacci/fibonacci3_circuit.h Outdated Show resolved Hide resolved
tachyon/zk/plonk/examples/fibonacci/fibonacci3_circuit.h Outdated Show resolved Hide resolved
tachyon/zk/plonk/examples/fibonacci/fibonacci3_circuit.h Outdated Show resolved Hide resolved
tachyon/zk/plonk/examples/fibonacci/fibonacci3_circuit.h Outdated Show resolved Hide resolved
@ashjeong ashjeong force-pushed the feat/implement-fibonacci-circuits branch from 7ca4f0a to 001d45c Compare May 20, 2024 02:09
@ashjeong ashjeong force-pushed the feat/implement-fibonacci-circuits branch from 001d45c to c30661b Compare May 20, 2024 02:27
dongchangYoo
dongchangYoo approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@dongchangYoo dongchangYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chokobole
chokobole approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@chokobole chokobole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole merged commit 3439208 into main May 20, 2024
3 checks passed
@chokobole chokobole deleted the feat/implement-fibonacci-circuits branch May 20, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chokobole chokobole chokobole approved these changes

@dongchangYoo dongchangYoo dongchangYoo approved these changes

@Insun35 Insun35 Insun35 approved these changes

@ashjeong ashjeong ashjeong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TomTaehoonKim @chokobole @dongchangYoo @Insun35 @ashjeong