Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement poseidon2 #413

Merged
merged 23 commits into from May 16, 2024
Merged

feat: implement poseidon2 #413

merged 23 commits into from May 16, 2024

Conversation

chokobole
Copy link
Contributor

Description

This PR implements Poseidon2 hash function.

These are the reference implementations.

@chokobole chokobole force-pushed the feat/implement-poseidon2 branch 3 times, most recently from c00e910 to 85184b6 Compare May 7, 2024 04:55
@chokobole chokobole marked this pull request as ready for review May 8, 2024 11:09
Copy link
Contributor

@TomTaehoonKim TomTaehoonKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dongchangYoo dongchangYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ashjeong ashjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

970bd23
Please fix "consistency" in the commit message
test(benchmark): benchmark only the permutation part for consistency w…
…ith Poseidon2

Copy link
Contributor

@ashjeong ashjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Insun35 Insun35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole merged commit 538c2e5 into main May 16, 2024
3 checks passed
@chokobole chokobole deleted the feat/implement-poseidon2 branch May 16, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants