build: support building with clang on ubuntu #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since a lint error has occurred in |
ashjeong
requested changes
May 13, 2024
There was a problem hiding this comment.
b30a8f6
Please change the commit title to a constexpr (with `) to match the commit before
bd15530
Please change the commit message to this:
When linking rust tests with clang, clang detects and tries to use the system installed intel openmp even when compiling without the option --//:has_intel_openmp,.
chokobole
force-pushed
the
build/support-building-with-clang-on-ubuntu
branch
2 times, most recently
from
a5753f9
to
fc2fff0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
chokobole
force-pushed
the
build/support-building-with-clang-on-ubuntu
branch
from
fc2fff0
to
9867ba5
Compare
When linking rust tests with clang, clang detects and tries to use the system installed intel openmp even when compiling without the option `--//:has_intel_openmp`.
chokobole
force-pushed
the
build/support-building-with-clang-on-ubuntu
branch
from
9867ba5
to
7699a73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables building tachyon with clang on ubuntu 22.04