-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement(scheduler): share waitingPods among profiles #124926
enhancement(scheduler): share waitingPods among profiles #124926
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/sig scheduling |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kerthcet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
kindly ping @Huang-Wei |
@kerthcet Thanks for constantly pushing this feature forward. LGTM |
/lgtm |
LGTM label has been added. Git tree hash: de035d6c0b44361ea193879c3f73481f485226c3
|
Let's track the real cause and fix in #123707. |
/retest |
1 similar comment
/retest |
What type of PR is this?
What this PR does / why we need it:
Share waitingPods among scheduler profiles to help us traverse all pods waiting in the permit stage within the current scheduler app, rather than the pods that using the current profile for scheduling and waiting in the permit stage.
Other context:
We revert this PR for goroutine leakage https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-unit/1770147457137643520, however, this may because klog reports the log too quick before waiting for the gorouine to complete, also see discussion here #123707. Sorry for the revert @NoicFank hope it's not too late.
Push this feature again and make you the main author. also cc @Huang-Wei
Which issue(s) this PR fixes:
Fixes #122945
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: