Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/kubelet: remove deprecated otel NewNoopTracerProvider #124956

Merged
merged 2 commits into from
Jun 7, 2024
Merged

cmd/kubelet: remove deprecated otel NewNoopTracerProvider #124956

merged 2 commits into from
Jun 7, 2024
+14 −11

Conversation

TommyStarK
Copy link
Contributor

@TommyStarK TommyStarK commented May 19, 2024 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

If applied this commit will replace the use of the deprecated go.opentelemetry.io/otel/trace.NewNoopTracerProvider
by the recommended go.opentelemetry.io/otel/trace/noop.NewTracerProvider.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@TommyStarK
cmd/kubelet: remove deprecated otel NewNoopTracerProvider
902a6b5 
Signed-off-by: TommyStarK <thomasmilox@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 19, 2024
@k8s-ci-robot k8s-ci-robot added area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/node Categorizes an issue or PR as relevant to SIG Node. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 19, 2024
endocrimes
endocrimes reviewed May 19, 2024
View reviewed changes
Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/triage accepted
/priority important-longterm
^ dependency health
/lgtm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels May 19, 2024
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 07e892b807f9af01afba6596cd6fac17de5afdf4

@bart0sh bart0sh added this to Needs Approver in SIG Node PR Triage May 20, 2024
@mrunalp
Copy link
Contributor

mrunalp commented May 21, 2024

Any reason to just update one file at a time? I see around ~30 instances in the repo which we can get together or do per component.

@endocrimes
Copy link
Member

@mrunalp I imagine that will mostly end up sitting in "waiting for approver" nightmare state for a while

@TommyStarK
Copy link
Contributor Author

TommyStarK commented May 22, 2024 •
edited

Yes exactly I thought it would be more efficient from an approval pov. I am planning to handle the others. However, for the apiserver as example changes are to be made under the staging folder first before being able to modify the pkg one otherwise tests are failing

@TommyStarK
kubelet: remove deprecated otel NewNoopTracerProvider
c0ed497 
Signed-off-by: TommyStarK <thomasmilox@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 22, 2024
@TommyStarK
Copy link
Contributor Author

@endocrimes @mrunalp I've updated the PR so the changes are applied to the kubelet related code under the cmd and pkg folders.

@TommyStarK
Copy link
Contributor Author

/retest-required

mrunalp
mrunalp approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a18e6d766a3ae55c4ea4bf8fb666a57927233458

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, TommyStarK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit f057f2d into kubernetes:master Jun 7, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Jun 7, 2024
@TommyStarK TommyStarK deleted the remove-deprecated-otel-noop-tracer branch June 7, 2024 00:17
@dims dims mentioned this pull request Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@odinuge odinuge Awaiting requested review from odinuge

@endocrimes endocrimes Awaiting requested review from endocrimes

Assignees

@mrunalp mrunalp

@endocrimes endocrimes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Status: Done
SIG Node PR Triage
Needs Approver
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TommyStarK @k8s-ci-robot @mrunalp @endocrimes