Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkpoint visualization tweaks #906

Merged
merged 6 commits into from
Mar 7, 2024
Merged

Conversation

jeffmerrick
Copy link
Collaborator

What type of PR is this?

  • 🍧 Refactor
  • 🔋 Optimization

Description

Screenshot 2024-03-06 at 5 06 09 PM

  • Checkpoint scatter plot and molstar visualization are moved to the same tab on experiment detail
  • Also moved into their own MetricsVisualizer component
  • For now I didn't create a reusable scatter plot component as this one is pretty tied to the state of the components around it
  • Changing some molstar styles requires scss which doesn't work with turbopack, so --turbo on dev removed
  • Weird prod build issue with molstar + swcMinify, so swcMinify disabled

Bonus 🎉

  • LAB-1309 rename tokens to points
  • Fixed file select behavior where the filters wouldn't reset as you moved between multiple file selects on the same page

Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Mar 7, 2024 0:59am

@acashmoney
Copy link
Contributor

The following alert comes up after npm run dev. Created issue #907 for tracking.

⚠ Disabling SWC Minifer will not be an option in the next major version. Please report any issues you may be experiencing to https://github.com/vercel/next.js/issues

Copy link
Contributor

@acashmoney acashmoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffmerrick I tested labsay checkpoint and it looks beautiful. I wanted to test colabdesign checkpoint as well, but I believe there's a container issue unrelated to your changes. So this looks good on my end.

I commented out the list of checkpoint files in MetricsVisualizer.tsx because we got a late request to remove these.

😍
Screenshot 2024-03-06 at 7 40 12 PM

⚖️
Screenshot 2024-03-06 at 7 41 53 PM

🖖
Screenshot 2024-03-06 at 8 02 42 PM

@acashmoney acashmoney merged commit 56e2379 into main Mar 7, 2024
16 checks passed
@acashmoney acashmoney deleted the checkpoint-visualization-tweaks branch March 7, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants