Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

LAB-1455 publish readonly #952

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

supraja-968
Copy link
Collaborator

@supraja-968 supraja-968 commented Apr 18, 2024

What type of PR is this?

  • 馃幃 Feature

Description

With this feature, the re-run experiment form turns to readonly after publishing, to avoid inconsistencies if the owner of the experiment makes any changes to the experiment after publish. With record versioning thats coming in future, this can be disabled, and user will be able to publish multiple versions of their experiments.
Changes made:

  1. Publish button is disabled while the experiment has any jobs that are not completed yet. Hover message shows "You can't publish until your experiments finish. Please try later"
  2. Once completed, the button is enabled with a hover message "Click to publish this experiment. Warning: Once published, you can't make changes"
  3. Once published, the re-run experiment form turns readonly, with the re-run experiment button color grey. the hover message on published button shows "Experiment has already been published, and is now read-only"
image image image

Copy link

linear bot commented Apr 18, 2024

Copy link

vercel bot commented Apr 18, 2024

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs 猬滐笍 Ignored (Inspect) Visit Preview Apr 19, 2024 5:34pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants