Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add redis cluster support #4284

Closed
wants to merge 7 commits into from
Closed

Conversation

maldinixiang
Copy link

Description

code does not support redis cluster mode,add suupport

Type of Change

  • New feature ()

How Has This Been Tested?

set REDIS_CLSUTER=1 and can connect to cluster redis

  • TODO

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 💪 enhancement New feature or request labels May 11, 2024
api/extensions/ext_redis.py Show resolved Hide resolved
web/yarn.lock Outdated Show resolved Hide resolved
api/app.py Outdated Show resolved Hide resolved
api/config.py Outdated Show resolved Hide resolved
api/core/helper/model_provider_cache.py Show resolved Hide resolved
api/config.py Outdated Show resolved Hide resolved
api/app.py Show resolved Hide resolved
@takatost
Copy link
Collaborator

You need to address these issues I've marked, or provide a valid reason.

@takatost
Copy link
Collaborator

Sorry, but I can't approve your PR since you keep closing request changes without providing a reason or making the necessary modifications.

@bowenliang123
Copy link
Contributor

bowenliang123 commented May 17, 2024

-1.

  1. redis-py does have clustering support, referring to https://redis-py.readthedocs.io/en/stable/clustering.html . No necessary to add an outdated package redis-py-cluster which is last updated at May 30, 2021.
  2. please properly fixed the comments raised.
  3. no unit tests.

@takatost takatost closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants