Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UNSTRUCTURED_API_KEY env support #4369

Merged
merged 1 commit into from
May 20, 2024

Conversation

majian159
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 💪 enhancement New feature or request labels May 14, 2024
@JohnJyong
Copy link
Contributor

UNSTRUCTURED_API_KEY is not a necessary variable , pls add the default value for it in the file config.py , thanks
@majian159

@JohnJyong JohnJyong self-requested a review May 14, 2024 11:52
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@majian159
Copy link
Contributor Author

UNSTRUCTURED_API_KEY is not a necessary variable , pls add the default value for it in the file config.py , thanks @majian159

Specifically, how should it be done? UNSTRUCTURED_API_KEY is similar in nature to UNSTRUCTURED_API_URL. I noticed that UNSTRUCTURED_API_KEY does not have any other default configuration in config.py.

@JohnJyong
Copy link
Contributor

After test, api_key works fine with None value , approved

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 20, 2024
@JohnJyong JohnJyong dismissed crazywoola’s stale review May 20, 2024 05:14

After test, api_key works fine with None value

@JohnJyong JohnJyong merged commit b520411 into langgenius:main May 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants