-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test,win: enable tcp_connect_error_after_write #4057
base: v1.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if it passes.
e1aef45
to
bf34061
Compare
For posterity, the write fails with EPIPE instead of EBADF, which I guess is as valid an error as any other?
|
ASSERT_EQ(r, UV_EBADF); | ||
#endif | ||
|
||
r = uv_tcp_connect(&connect_req, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might have made a rebase mistake?
2: not ok 314 - tcp_connect_error_after_write
2: # exit code -1073740791
2: # Output from process `tcp_connect_error_after_write`:
2: # Assertion failed in D:\a\libuv\libuv\test\test-tcp-connect-error-after-write.c on line 85: `r == 0` (-4047 == 0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, STATUS_STACK_BUFFER_OVERRUN? I'll take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still happens after a rebase, with changes only to the test file. -4047 is UV_EPIPE and that's a basically impossible return code from uv_run() so I guess that means the buffer overrun status code doesn't come out of completely thin air.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We used to have an ASAN test until it seemed that GithubActions updated something and broke it: #4210
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems that ASAN didn't have anything to report
not ok 314 - tcp_connect_error_after_write
# exit code -1073740791
# Output from process `tcp_connect_error_after_write`:
# Assertion failed in D:\a\libuv\libuv\test\test-tcp-connect-error-after-write.c on line 85: `r == 0` (-4047 == 0)
67514d9
to
d905453
Compare
The test was added in 2012 but never enabled on Windows. Let's see how it fares anno 2024.
d905453
to
eeae108
Compare
The test was added in 2012 but never enabled on Windows. Let's see how it fares anno 2023.