win: implement battery (Draft) #4271
Conversation
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
|
The results in my VM (no battery) are the following: I also ran the tests on a Windows laptop, which resulted in: Which is essentialy the same data I get on the browser API. |
Initial implementation of uv battery api for Win32
| #include "winapi.h" | ||
|
|
||
| int uv__estimate_remaining_charging_time_in_seconds(SYSTEM_POWER_STATUS* sys_power_status) { | ||
| int remaining; |
There was a problem hiding this comment.
Style nits:
- 2 space indent, not 4
- lines should be <= 80 columns
This function is only used in this file so it should be static. That sys_power_status argument is used a lot so I'd give it a short name like sps or simply just p.
| if (sys_power_status->ACLineStatus != 1) { | ||
| remaining = -1; | ||
| goto out; | ||
| } |
There was a problem hiding this comment.
No need to goto here, you can just return early, likewise below:
if (sys_power_status->ACLineStatus != 1)
return -1;(for some reason I can't post it as a diff)
| int err; | ||
|
|
||
| if (!GetSystemPowerStatus(&sys_power_status)) { | ||
| err = /* Not sure... */1; |
There was a problem hiding this comment.
Probably should call GetLastError() and convert with uv_translate_sys_error()?
|
I will update this PR soon |
|
@oluan : do you intend to add implementations for other OS'es? |
|
Are the maintainers likely to accept this new API? |
| // (battery and/or UPS's) are empty | ||
| // Convert minutes into seconds | ||
| if (info->charging > 0) info->charging *= 60; | ||
|
|
There was a problem hiding this comment.
this function only populates the charging field (which doesn't exist, see below) of the info structure, the other fields should be given meaningful values
| // Anything else the estimated minutes remaining until all power sources | ||
| // (battery and/or UPS's) are empty | ||
| // Convert minutes into seconds | ||
| if (info->charging > 0) info->charging *= 60; |
There was a problem hiding this comment.
there is no field named charging, did you intend this to be the discharge_time_in_secs field?
|
Looks like I missed the corresponding #4258 for Linux/macos so my comments here do not appear to be relevant |
This is my initial implementation (WIP) of the battery API on Windows.
I left some comments in the code.